fix: report generation errors to sentry w/ model name #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambarnes
commented
Jan 12, 2024
Comment on lines
+120
to
+122
| logging.exception( | ||
| "Failed generation", extra={"model": self.engine_args.model} | ||
| ) |
There was a problem hiding this comment.
opted to not convert the above print( to logging.info yet because in my test it did not show on modal (i think its because the default logger is set to WARN level, but we can followup with logging everywhere later. just a targeted change here for now)
There was a problem hiding this comment.
I hit the same thing, logging.basicConfig(level=logging.INFO) fixed it
montasaurus
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
previously, any errors during the
generate(method would only get printedbecause the
sentry_sdkis already initialized by the time this logic is hit, we can uselogging.exception(to bubble up to sentrythe log entry in modal will be more visible with the ERROR level, and automatically includes the stack trace because of the
.exception(use instead of plain.error(additionally, i've included the model in the extra params. doesn't look like it shows in modal but it will show in datadog once thats hooked up. its already visible in the sentry error tho:
Code of Conduct