Improve layout of test details window #239
Conversation
This function adds a new row to the given table body. The row contains 2 columns, the first column is a bold text and the second column is a normal text. A HTML element can be put instead of a text into the second column. The purpose of the function is to facilitate displaying key-value data pairs in HTML tables.
- make the layout more compact to show all related data at a single place - For OVAL objects, create a table where each child element is represented as a table row - OVAL object child elements tag name is shown as first column in the row - OVAL object child elements text data shown as second column in the row - OVAL object child elements attributes are shown as labels - OVAL states and OVAL variables are presented in a similar way as OVAL objects as described above - make sure the test details window is standalone
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
openscap_report/report_generators/html_templates/js/oval_graph_generation_script.js
Fixed
Show fixed
Hide fixed
|
One big problem with this PR that I found is that now it doesn't show the direct child elements of In the current main branch it is also not ideal but there is at least the tag name printed. I think the name of the direct child element should be a special row in the "OVAL variable" table. It's also important to add their attributes because for example the |
The UUID is important to distinguish between two items of the same name stored in an internal directory. But it shouldn't be disaplayed to the user.
This change will cause that elements like `<set>` and OVAL variable child elements (`<count>`, `<arithmetic>`, `<time_difference>`) will be displayed in the HTML report.
It's important to add attributes of these elements because they are significant for understanding the operation performed. For example, the arithmetic element has the arithmetic operation in the arithmetic_operation attribute. This commit also simplifies the generator code.
|
LGTM, I reviewed the code changes and tested it on the latest Fedora. |
this is solved in the 2 latest comments |
|
I think that more visual improvements should be done in a separate PR to not increase the size of this PR. |
place
represented as a table row
as OVAL objects as described above
Any suggestions are welcome. I would appreciate advice on the classes of the HTML elements. Feel free to come up with layout suggestions. I'm also interested in you experience in more complex OVAL tests. Please try it out and report back.