Remove obsolete template options #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option --template allows users to provide either a remediation system URN or a custome XSLT template path. Instead of using the --template with URN users should use --fix-type. A custom XSLT path have never really worked. Users can apply custom XSLTs on their XML files using xsltsproc tool or other third party tools, they don't need oscap for that. We advise users to use --fix-type to specify the remediation type. The --oval-template and --sce-template options are also useless because the result file names are defined by oscap itself, therefore there is no other sensible value for these options than the default value (hardcoded in oscap).
comps
added a commit
to RHSecurityCompliance/contest
that referenced
this pull request
Aug 18, 2024
It seems --template was removed in OpenSCAP v1.4, and --fix-type
seems to be a better fit here anyway.
OpenSCAP/openscap#2134
It's also used in other ansible tests instead of --template.
The resulting playbook is exactly the same.
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
mildas
pushed a commit
to RHSecurityCompliance/contest
that referenced
this pull request
Aug 20, 2024
It seems --template was removed in OpenSCAP v1.4, and --fix-type
seems to be a better fit here anyway.
OpenSCAP/openscap#2134
It's also used in other ansible tests instead of --template.
The resulting playbook is exactly the same.
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option --template allows users to provide either a remediation system URN or a custom XSLT template path. Instead of using the --template with URN users should use --fix-type. A custom XSLT path have never really worked. Users can apply custom XSLTs on their XML files using xsltsproc tool or other third party tools, they don't need oscap for that. We advise users to use --fix-type to specify the remediation type.
The --oval-template and --sce-template options are also useless because the result file names are defined by oscap itself, therefore there is no other sensible value for these options than the default value (hardcoded in oscap).