Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing headers if t_reply_body is used inside a failure route block #3424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Riccardo-78
Copy link

Summary

This PR fixes append_to_reply not working when t_reply_with_body is used inside a failure_route block

Details

see linked issue

Solution

added update_cloned_msg_from_msg to the failure_route case.

Compatibility

Closing issues

closes #3422

@bogdan-iancu bogdan-iancu self-requested a review July 2, 2024 13:57
@bogdan-iancu bogdan-iancu self-assigned this Jul 2, 2024
@Riccardo-78
Copy link
Author

I was wondering if there’s anything holding back the merge of my pull request? Let me know if I can assist with anything!

@bogdan-iancu
Copy link
Member

Hi @Riccardo-78 - thanks for the PR here. Nevertheless, I'm not convinced this is the right fix. If we do update_cloned_msg_from_msg in the failure route, then all the changes you did in failure route will stick the transaction for all the future branches, not only for the current branch. Which is not the intended behavior (in failure route, your changes impact only the branches you create at that very moment, not all the future ones).
I think it is a deeper problem with the t_reply_with_body function - as the comment here, the problem is that the function takes as param the request from the transaction, not the current sip_msg provided from the script level - not sure why, I can check on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] append_to_reply not working when t_reply_with_body is used inside a failure_route block
2 participants