db_sqlite: new parameters and minor improvements #3545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptr->con is always NULL at this moment
sqlite3_db_config with SQLITE_DBCONFIG_ENABLE_LOAD_EXTENSION affects only C-API without enabling SQL function load_extension()
The proper way to handle a locked database is to use a busy timeout. Previously, the behavior resulted in an infinite lock for the process attempting to write to the locked database. The default value for the busy timeout has been set to 500 ms to avoid immediate errors when short database locks occur.
vasilevalex
force-pushed
the
sqlite_params
branch
2 times, most recently
from
eb8d1b3 to
c307279
Compare
vasilevalex
force-pushed
the
sqlite_params
branch
from
c307279 to
0cdbb85
Compare
|
@vasilevalex , thanks for your contribution here. Do you think it is doable to split PR into "fixes" and "new stuff" ? Why? as if we do this, we can backport the "fixes". Otherwise, as mixed with new features, the backport will not be possible. |
|
yes, sure, I'll split it in 2 PRs |
|
Thanks @vasilevalex . For the new stuff, will you rebase this PR or create a new one (and trash this one) ? |
|
Hi @bogdan-iancu . I'll make new one tomorrow, then I need to add information here and will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
The PR was started as new feature, but fixed some issues during implementation.
Solution
Please review commits
Compatibility
The original behavior has been changed. If the database is locked, the process attempting to access it will no longer enter an infinite loop. Instead, it will return an error after the default timeout of 500 ms (this value can be modified as module parameter).