dispatcher: fix persistent_state #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @babakyakhchali |
bogdan-iancu
added a commit
that referenced
this pull request
Feb 7, 2025
dispatcher: fix persistent_state (cherry picked from commit a0feb32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue 3567 in dispatcher module, currently setting persistent_state to enabled is not working and destinations state is not stored in database when opensips service is restarted, or based on timer callback.
Details
This PR fixes dispatcher persistence problem by changing the way value of persistent_state is checked.
Solution
Instead of using str_strcmp function output directly, it's return value must be checked with 0 which this pull request tries to do.
Compatibility
This PR will not break other scenarios.
Closing issues
closes #3567