[ADD] OpenSpp Adaptor #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatnm0612
requested review from
jeremi,
reichie020212,
emjay0921 and
gonzalesedwin1123
jeremi
requested changes
Jun 19, 2023
| ]; | ||
| let defaultFields = [ | ||
| "individual", "kind", "start_date", "ended_date", | ||
| "individual_birthdate", "individual_gender" |
There was a problem hiding this comment.
Those field ("individual_birthdate", "individual_gender") are not in the default implementation of OpenSPP I think.
Try the code with a fresh install with openspp-docker.
There was a problem hiding this comment.
You are right, this is not in OpenSPP, but is implemented by you in OpenG2P repo. (link here)
And I think that it is good to have.
| sppConnector.connect((err) => { | ||
| if (err) { | ||
| Log.error(err); | ||
| throw new Error("Can't login to OpenSPP, please check your credentials or network!"); |
There was a problem hiding this comment.
Do we have more details in the error we can give to the users?
`msgraph` adaptor
New expandReferences API
Fix opinionator
Mailgun: update to mailgun.js
1) Don't try to expand a stream 2) don't callback at the with an empty chunk
it was not being used
Fix streaming interface to parseCSV
`msgraph` support stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add adaptor for OpenSpp
Details
Based on npm module Odoo [https://www.npmjs.com/package/odoo].
Creating a adaptor for OpenSPP with these functions:
registrant_id is from: https://github.com/OpenSPP/openspp-registry/issues/247
Implement the methods:
Issues
Issue
Review Checklist
Before merging, the reviewer should check the following items:
migration guide followed?
dev only changes don't need a changeset.