Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin jwcrypto and requests libraries to ensure safe version is used #562

Draft
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

kneckinator
Copy link
Contributor

Why is this change needed?

Pinning libraries to a safe version (or newer) ensures that other dependencies cannot downgrade these libraries to vulnerable versions

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.23%. Comparing base (c1dcb86) to head (bb62a74).
Report is 13 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #562      +/-   ##
==========================================
- Coverage   76.25%   76.23%   -0.02%     
==========================================
  Files         687      687              
  Lines       17777    17777              
  Branches     2205     2205              
==========================================
- Hits        13556    13553       -3     
- Misses       3773     3774       +1     
- Partials      448      450       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kneckinator kneckinator requested a review from jeremi September 3, 2024 01:53
Copy link

sonarqubecloud bot commented Sep 3, 2024

@kneckinator kneckinator marked this pull request as draft September 9, 2024 09:35
@kneckinator
Copy link
Contributor Author

Rebasing this branch on the latest 17.0 and taking a look at the current state of our third-party dependencies to understand whether they are compatible with the proposed update. If so, I will change this PR from draft to a PR that can be merged.

Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant