Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Interact Fixes #116

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

abhayks1
Copy link
Contributor

@abhayks1 abhayks1 commented Feb 25, 2019

PR covers few fixes while integration with recovery:

  • primaryType mismatch fix.

  • As per EIP712 domainSeparator, signing domain for address should be

  bytes32 public constant DOMAIN_SEPARATOR_TYPEHASH = keccak256(
        "EIP712Domain(address  verifyingContract)"
    );

Gnosis also follows same domain signing field name:
https://github.com/gnosis/safe-contracts/blob/development/contracts/GnosisSafe.sol

keccak256(
       "EIP712Domain(address verifyingContract)"
   );
  • However for recovery DOMAIN_SEPARATOR_TYPEHASH is below:
bytes32 public constant DOMAIN_SEPARATOR_TYPEHASH = keccak256(
        "EIP712Domain(address delayedRecoveryModule)"
    );

Copy link
Contributor

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; for hotfix; openst-contracts DelayedRecoveryModule must be updated to correctly follow EIP712

@benjaminbollen benjaminbollen merged commit d9792b9 into OpenST:develop Feb 25, 2019
@abhayks1 abhayks1 deleted the recovery_fixes branch February 26, 2019 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants