Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl_base.h: translated #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

majklvi
Copy link
Contributor

@majklvi majklvi commented Dec 20, 2023

No description provided.

@janrysavy janrysavy added the comments translation Translation of code comments from Czech to English label Dec 20, 2023
#pragma pack(4)
#pragma warning(3 : 4706) // warning C4706: assignment within conditional expression
#endif // _MSC_VER
#ifdef __BORLANDC__
#pragma option -a4
#endif // __BORLANDC__

// v debug verzi budeme testovat, jestli se neprekryvaji zdrojova a cilova pamet (pro memcpy se nesmi prekryvat)
// in debug version, we will test if source and destination memory overlap (memcpy must not overlap)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// in the debug version, we will test whether the source and destination memory do not overlap (for memcpy, they must not overlap)

// POZOR: nutne zapnout tez pro kazdy plugin zvlast
// makro CALLSTK_DISABLEMEASURETIMES - potlaci mereni casu straveneho pri priprave call-stack hlaseni v DEBUG/SDK/PB verzi
// macro CALLSTK_MEASURETIMES - enables measuring of time spent by preparing call-stack messages (ratio against
// total time of functions is measured)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(...) -> (measured as a ratio against the total runtime of the functions)

// ve vsech volanych metodach pluginu je mozne CALL_STACK metody pouzit primo,
// tato metoda se pouziva pouze pro nove thready pluginu,
// spousti funkci 'threadBody' s parametrem 'param', vraci vysledek funkce 'threadBody'
// loads into thread the things needed for CALL-STACK methods (see Push and Pop below),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loads into thread -> introduces to the thread

#define MENU_EVENT_ARCHIVE_FOCUSED 0x2000
// uz je k dispozici jen 0x4000 (masky se skladaji obe do DWORDu a predtim se maskuji 0x7FFF)
// only 0x4000 is available (the mask is composed of two DWORDs and before it is masked by 0x7FFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(both masks are masked with 0x7FFF and merged to DWORD)

// thumbnail loaders - see CPluginInterfaceForThumbLoaderAbstract.
// The parts are connected to CPluginInterfaceAbstract through CPluginInterfaceAbstract::GetInterfaceForXXX

// flags indicating which functions the plugin provides (which methods of CPluginInterfaceAbstract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(...) -> (which methods of the descendant CPluginInterfaceAbstract are actually implemented in the plugin)

of configuration - CURRENT_CONFIG_VERSION (in the first version of method Connect
is CURRENT_CONFIG_VERSION=1)
- to basic part (before conditions "if (ConfigVersion < YYY)"):
- code for installation of plugin is written (first load of plugin):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent this line

or added some, he has bad luck, he will have to do it manually again)
- AddMenuItem, SetChangeDriveMenuItem and SetThumbnailLoader works with every load
of plugin the same (installation/upgrades do not differ - it always starts from scratch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

- AddMenuItem, SetChangeDriveMenuItem and SetThumbnailLoader works with every load
of plugin the same (installation/upgrades do not differ - it always starts from scratch)

- during upgrades only: into the part for upgrades (for the basic part):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(...) -> (after the basic part)

for "panel archiver")
-mask "*.dmp2" was added to AddViewer (because we add extension "dmp2" for "viewer")
-condition for upgrade to version 3 was added + comment for this upgrade,
body of condition:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

-mask "*.dmp2" was added to AddViewer (because we add extension "dmp2" for "viewer")
-condition for upgrade to version 3 was added + comment for this upgrade,
body of condition:
-calling AddPanelArchiver for extension "dmp2" with 'updateExts' TRUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comments translation Translation of code comments from Czech to English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants