Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sublink dimension name in pynncml_basic_example.ipynb #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cchwala
Copy link
Member

@cchwala cchwala commented Sep 15, 2023

There were changes in the data transformation code, which now only returns a xarray.Dataset with reshaped data and updated dimension (cml_id, sublink_id, time) if it is called with the option to reshape the data. Since reshaping the data takes too long to run (an might crash on binder due to limited RAM) the simplest fix is to not reshape and just use the sublink dimension as it is called in the existing OpenMRG NetCDF file.

At some point, the pynncml example could use the smaller example NetCDF from the OpenMRG dataset that is currently (since #62) part of the sandbox repository.

There were changes in the data transformation code, which now only returns a xarray.Dataset with reshaped data and updated dimension (cml_id, sublink_id, time) if it is called with the option to reshape the data. Since reshaping the data takes too long to run (an might crash on binder due to limited RAM) the simplest fix is to not reshape and just use the `sublink` dimension as it is called in the existing OpenMRG NetCDF file.

At some point, the pynncml example could use the smaller example NetCDF from the OpenMRG dataset that is currently part of the sandbox repository.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch OpenSenseAction/OPENSENSE_sandbox/pynncml_sublink_kwarg

@cchwala cchwala changed the title fix sublink kwarg in pynncml_basic_example.ipynb fix sublink dimension name in pynncml_basic_example.ipynb Sep 15, 2023
results are bad, maybe because the time series is too short for the
applied method
@cchwala
Copy link
Member Author

cchwala commented Sep 15, 2023

Note: In the last commit it did what I suggested above:

At some point, the pynncml example could use the smaller example NetCDF from the OpenMRG dataset that is currently (since #62) part of the sandbox repository.

The problem is that the final rain rates estimations does not seem to work, maybe because the time series is too short now.

@haihabi Can you have a look at the notebook? Maybe you can fiddle with it directly in binder based on the link above to find out what is going wrong. If the reason is that the time series is too short, we will have to switch back to downloading the full OpenMRG dataset just using the fix from my first commit in this PR.

I tried to fix this now, because it would be great to have your notebook working when the sandbox is promoted during the training school in October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant