Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing notebook, data_preparation corrections and adjust_radar draft #8

Merged
merged 12 commits into from
Feb 12, 2025

Conversation

EliaCovi
Copy link
Contributor

@EliaCovi EliaCovi commented Jan 31, 2025

@cchwala
Copy link
Member

cchwala commented Feb 11, 2025

Thanks for moving this forward. Please comment here once you think this PR is ready to merge.

@EliaCovi EliaCovi changed the title Processing notebook and data preparation corrections Processing notebook, data_preparation corrections and adjust_radar draft Feb 11, 2025
@EliaCovi
Copy link
Contributor Author

Thanks for moving this forward. Please comment here once you think this PR is ready to merge.

I think it's ready. I decided to add in this PR the first draft of 3_adjust_radar (if it's too early I'll try to remove it).

@cchwala
Copy link
Member

cchwala commented Feb 12, 2025

Yes, that is perfect. I had a quick look at the notebook 3 with the radar adjustment and it is good, but as far as I see the results for OpenRainER are not yet good, for CMLs... So we should iterate things further. For now, it is great to have the full consistent workflow with notebook 1, 2 and 3 💪.

This will close #6

We can also close #7 and open a new issue to discuss, and potentially improve, the OpenRainER merging results.

@cchwala
Copy link
Member

cchwala commented Feb 12, 2025

...and potentially improve, the OpenRainER merging results.

As discussed via chat, the current results for OpenRainER are using gauge-adjusted radar, hence, the radar data fits the gauges very good. @EliaCovi will switch to unadjusted radar soon and the radar-CML adjustment should then show the expected results. So, nothing to worry currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants