Skip to content

Conversation

@LucHeart
Copy link
Member

Summary

  • ensure the updater overwrites the downloaded installer using FileMode.Create with write access

Testing

  • dotnet publish Desktop/Desktop.csproj -c Release-Photino -o ./publish/Photino-Linux (fails: dotnet is not installed in the container)

https://chatgpt.com/codex/tasks/task_e_68f752b83fd08327ab064b017f7665c6

Copilot AI review requested due to automatic review settings October 21, 2025 14:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a file handling issue in the updater service by ensuring downloaded installers are properly overwritten. The change replaces FileMode.OpenOrCreate with FileMode.Create and explicitly specifies write-only access with no file sharing to prevent file access conflicts during updates.

Key Changes:

  • Modified file stream creation in the updater to use FileMode.Create instead of FileMode.OpenOrCreate
  • Added explicit FileAccess.Write and FileShare.None parameters for safer file handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LucHeart LucHeart changed the base branch from master to develop October 21, 2025 14:09
@LucHeart LucHeart merged commit 0fd3332 into develop Oct 21, 2025
9 checks passed
@LucHeart LucHeart deleted the codex/find-and-fix-a-bug branch October 21, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants