-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge performance improvements (43% faster FFmpegReader, 34% faster Timeline) #638
Commits on Feb 4, 2021
-
Improving performance after working with google-prof, to profile CPU.…
… Calling OMP_MP_NUM_PROCESSORS less often, since it's quite expensive according to profiling. Adjusting Timeline final_cache to match the video caching thread max_frames, so one doesn't clobber the other. Also, fixing an issue with openshot-player, where a video file with no audio skips horribly.
Configuration menu - View commit details
-
Copy full SHA for 0c4e1bc - Browse repository at this point
Copy the full SHA 0c4e1bcView commit details
Commits on Feb 6, 2021
-
Reducing the # of threads on the Timeline in half, with a minimum of …
…4. Trying to experiment and reduce stuttering.
Configuration menu - View commit details
-
Copy full SHA for 15695e3 - Browse repository at this point
Copy the full SHA 15695e3View commit details
Commits on Feb 18, 2021
-
Large refactor of OpenMP integration (or rather the removal of OpenMP…
… on the Timeline and FFmpeg-related classes). The logic behind this decision, was based on profiling libopenshot and the amount of wasted CPU idle time on all the various threads. The slow code is still synchronous, and all the threads must wait on each other, adding additional overhead. So, removing lots of unneeded threads, and simplifying the underlying Timeline->Clip->FFmpegReader flow. Also, removed 2 calls to QPainter::drawImage, by improving the flexibility of Clip->GetFrame.
Configuration menu - View commit details
-
Copy full SHA for 3daa5bd - Browse repository at this point
Copy the full SHA 3daa5bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66eb3d5 - Browse repository at this point
Copy the full SHA 66eb3d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 563c8fd - Browse repository at this point
Copy the full SHA 563c8fdView commit details -
Removing caching from Clip object. Causes too many issues and does no…
…t add any performance (in my tests)
Configuration menu - View commit details
-
Copy full SHA for 0e30ecc - Browse repository at this point
Copy the full SHA 0e30eccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb842d - Browse repository at this point
Copy the full SHA 6cb842dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6012fc9 - Browse repository at this point
Copy the full SHA 6012fc9View commit details
Commits on Feb 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8280e20 - Browse repository at this point
Copy the full SHA 8280e20View commit details