Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge performance improvements (43% faster FFmpegReader, 34% faster Timeline) #638

Merged
merged 9 commits into from
Feb 25, 2021

Commits on Feb 4, 2021

  1. Improving performance after working with google-prof, to profile CPU.…

    … Calling OMP_MP_NUM_PROCESSORS less often, since it's quite expensive according to profiling. Adjusting Timeline final_cache to match the video caching thread max_frames, so one doesn't clobber the other. Also, fixing an issue with openshot-player, where a video file with no audio skips horribly.
    jonoomph committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    0c4e1bc View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2021

  1. Reducing the # of threads on the Timeline in half, with a minimum of …

    …4. Trying to experiment and reduce stuttering.
    jonoomph committed Feb 6, 2021
    Configuration menu
    Copy the full SHA
    15695e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Large refactor of OpenMP integration (or rather the removal of OpenMP…

    … on the Timeline and FFmpeg-related classes). The logic behind this decision, was based on profiling libopenshot and the amount of wasted CPU idle time on all the various threads. The slow code is still synchronous, and all the threads must wait on each other, adding additional overhead. So, removing lots of unneeded threads, and simplifying the underlying Timeline->Clip->FFmpegReader flow. Also, removed 2 calls to QPainter::drawImage, by improving the flexibility of Clip->GetFrame.
    jonoomph committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3daa5bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    66eb3d5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    563c8fd View commit details
    Browse the repository at this point in the history
  4. Removing caching from Clip object. Causes too many issues and does no…

    …t add any performance (in my tests)
    jonoomph committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    0e30ecc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6cb842d View commit details
    Browse the repository at this point in the history
  6. Re-enable Zmq logging

    jonoomph committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    6012fc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Configuration menu
    Copy the full SHA
    8280e20 View commit details
    Browse the repository at this point in the history