-
Notifications
You must be signed in to change notification settings - Fork 292
Add shadow effect to libopenshot
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ss for better encapsulation
… for alpha support
…nstructor documentation
…ries and improve code clarity
… Shadow effect JSON output
…operties from float to int for consistency
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #999 +/- ##
===========================================
- Coverage 57.29% 57.01% -0.28%
===========================================
Files 198 200 +2
Lines 18148 18270 +122
===========================================
+ Hits 10397 10417 +20
- Misses 7751 7853 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi, this PR is related to #998. Please check it out first. I also included test cases for that pull request! |
Currently there are no drop shadow effect implemented in
libopenshot
. To achieve that, people usually do this trick:This approach has two disadvantages:
My implementation of Shadow effect could solves those disadvantages by two features:
Please check this out! All contributions are appreciated!