Protecting from missing attributes

OpenShot · Mar 16, 2021 · ea93464 · ea93464
1 parent e10f970
commit ea93464
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/windows/main_window.py b/src/windows/main_window.py
@@ -2285,7 +2285,7 @@ def addSelection(self, item_id, item_type, clear_existing=False):
 
                 effect = Effect.get(id=item_id)
                 if effect:
-                    if effect.data["has_tracked_object"]:
+                    if effect.data.get("has_tracked_object"):
                         # Show bounding boxes transform on preview
                         clip_id = effect.parent['id']
                         self.KeyFrameTransformSignal.emit(item_id, clip_id)
@@ -2296,8 +2296,6 @@ def addSelection(self, item_id, item_type, clear_existing=False):
             self.show_property_type = item_type
             self.show_property_timer.start()
 
-
-
     # Remove from the selected items
     def removeSelection(self, item_id, item_type):
         # Remove existing selection (if any)

diff --git a/src/windows/views/properties_tableview.py b/src/windows/views/properties_tableview.py
@@ -580,7 +580,7 @@ def contextMenuEvent(self, event):
                         tracked_objects = []
                         for effect in clip_instance_data["effects"]:
                             # Check if effect has a tracked object
-                            if effect["has_tracked_object"]:
+                            if effect.get("has_tracked_object"):
                                 # Instantiate the effect
                                 effect_instance = timeline_instance.GetClipEffect(effect["id"])
                                 # Get the visible object's ids

diff --git a/src/windows/views/webview.py b/src/windows/views/webview.py
@@ -3027,11 +3027,11 @@ def callback(self, effect_names, callback_data):
 
                         # Get Effect JSON
                         effect.Id(get_app().project.generate_id())
-                        
+
                     effect_json = json.loads(effect.Json())
 
                     # Generate box_id for the TrackedObjectBBox object
-                    if effect_json["has_tracked_object"]:
+                    if effect_json.get("has_tracked_object"):
                         for object_id_index in range(len(effect_json["objects_id"])):
                             boxId = get_app().project.generate_id()
                             effect_json["objects_id"][object_id_index] = boxId