Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add to timeline" dialog contains no files or only one #3240

Closed
PontiacCZ opened this issue Feb 23, 2020 · 3 comments · Fixed by #3312
Closed

"Add to timeline" dialog contains no files or only one #3240

PontiacCZ opened this issue Feb 23, 2020 · 3 comments · Fixed by #3312
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) 🐞 bug A bug, error, or breakage of any kind

Comments

@PontiacCZ
Copy link

Describe the bug:
The "Add to timeline" (CTRL + W) dialog contains no files or only one depending on how you select files in the "Project Files" window.

Steps to reproduce the behavior:

  1. download these two free videos in FullHD:
  2. import then into OpenShot 2.5.0 by dragging
  3. activate the OpenShot app but don't click on any of the two files. Press CTRL + A to select them and then press CTRL + W - "Add to timeline" dialog appears
  4. there are no files in the dialog. It looks like this:

image

  1. return back to the Project Files window. Now click the Golden Gate video and then, with SHIFT, the Fire video. They're both selected so they should both go into the "Add to timeline" dialog, right?
  2. press CTRL + W. There is only the first selected video (Golden Gate) there. The same happens if you select the Fire video as first - then only the Fire video is present there:

image

Expected behavior:
All selected videos should be displayed in the "Add to timeline" window

System Details:

  • OpenShot Version [e.g. 2.4.3]: 2.5.0
  • Operating System / Distro: Windows 10 Pro x64
@PontiacCZ PontiacCZ added the 🐞 bug A bug, error, or breakage of any kind label Feb 23, 2020
@ferdnyc
Copy link
Contributor

ferdnyc commented Feb 23, 2020

Hmm. I couldn't immediately reproduce the bug as reported, but there is something weird going on with selection in the Project Files list and Add to Timeline. You can see here that, after selecting all videos in the list, I deselected the first one — but it was still on the list when I opened the dialog. (That's an easier problem to work around, since you can always use the ➖ icon to remove the extra video from the list, but it still points to a bug in how the selection list is handled.)

Screenshot from 2020-02-23 10-58-50

@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Feb 23, 2020
@nanohtpc
Copy link

same problem here.... it only happens when you used the keyboard shorcuts....

@SuslikV
Copy link
Contributor

SuslikV commented Mar 12, 2020

Small update. Info for the developers.

The Ctrl+A selects all indexes not only first column rows for QListView.

For the Thumbnails view:

  • Mouse selection - 0,0; 1,0; 2,0...;
  • Ctrl+A selection - 0,0; 0,1; 0,2; 0,3; 0,4; 0,5; 1,0; 1,1...; - all six columns indexes same as in Tree/Details view)

I can forget this, so as remainder: selection algorithm in OpenShot only requires row to get the selected item (file).

The PR will be a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) 🐞 bug A bug, error, or breakage of any kind
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants