Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Titles not working in latest Daily Build #3759

Closed
sc0nway opened this issue Oct 13, 2020 · 6 comments · Fixed by #3761 or #3763
Closed

Animated Titles not working in latest Daily Build #3759

sc0nway opened this issue Oct 13, 2020 · 6 comments · Fixed by #3761 or #3763
Assignees
Labels
📅 Daily Build This is an issue involving a daily build. 🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue

Comments

@sc0nway
Copy link
Collaborator

sc0nway commented Oct 13, 2020

Operating System: macOS Catalina 10.15.7
OpenShot Version: OpenShot-v2.5.1-dev2-1602472203-414a2cda-12ddb3df-x86_64.dmg
System Specifications: MacBook Pro 16 (2019) / Intel i9-9880H @ 2.4 GHz / 16GB / 512GB / Radeon Pro 5500M 8GB

When creating a new animated title in OpenShot 2.5.1-dev2 (October 11, 2020) using Blender 2.90.1, I selected the Neon Curves title then set the options. I set the File Name, then the Title, which includes two text lines, and set the rest of the options. When I refresh the preview window, it shows the title with one text line with a \n character between the two lines that I created (see image). I was expecting to see two text lines in the preview window for the title that I selected. When I rendered the title, the result was a single text line with a \n between the two texts that I created. I uninstalled Blender 2.90.1, installed Blender 2.80, then created a new project and a new animated title but had the same issue.

I then tried this on my Windows 10 (2004 10.0.19041.508) and Linux (Ubuntu 20.04 LTS) systems, which have OpenShot 2.5.1-dev2 (October 11, 2020), but had the same result. I launched my Linux (Ubuntu 20.04 LTS) VM and my Windows 10 (2004 10.0.19041.508) VM, which have OpenShot 2.5.1 and Blender 2.80, and recreated the title with two lines of text without the \n character.

Screen Shot 2020-10-13 at 4 04 57 PM

@sc0nway sc0nway added 🐞 bug A bug, error, or breakage of any kind 📅 Daily Build This is an issue involving a daily build. labels Oct 13, 2020
@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 14, 2020

Oh! Seems we're not protecting multi-line strings properly in the generated script. Thanks for the detailed report, should hopefully be an easy fix.

@ferdnyc ferdnyc self-assigned this Oct 14, 2020
@ferdnyc ferdnyc added the pending A PR has been submitted to fix the issue label Oct 14, 2020
@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 14, 2020

It was easy to fix, but I took the opportunity to beef up the entire way we pass parameters to the script, so that hopefully there won't be any more issues like this cropping up in the future.

@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 14, 2020

Whenever a set of Daily Builds pops out with PR #3761 incorporated (which may take half an hour or more to settle out, as I just merged a bunch of PRs in quick succession), this should be fixed for all animated title templates.

@sc0nway
Copy link
Collaborator Author

sc0nway commented Oct 14, 2020

Thanks, @ferdnyc
This works like a charm on my MacBook Pro.

However, when I tried the same title on my Windows 10 system with the latest Daily Build, the preview screen shows the OpenShot logo instead of my title, even after pressing Refresh.
Screenshot01

When I click the Render button, OpenShot passes information to Blender which generates and renders 250 PNG images. When the rendering is finished I receive an error message stating: Title%04d.png is not a valid video, audio, or image file.
Screenshot02

When I click the OK button, the dialog disappears and there is no title in my Project Files list.

@ferdnyc
Copy link
Contributor

ferdnyc commented Oct 15, 2020

@USATechDude Yup, turns out the Windows paths weren't being properly embedded in the script. Should be fixed by #3763, which I'll merge as soon as Travis is done with it.

Thanks again for the detailed testing. #TIL that my Windows laptop is too old and pathetic to run current versions of Blender (sigh), and I don't have access to a Mac at all, so all I can really determine for this stuff is "Hey, works on Linux" which isn't exactly end-to-end testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📅 Daily Build This is an issue involving a daily build. 🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue
Projects
None yet
2 participants