Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker picks the wrong value if dialog has dark background #3798

Closed
strattonbrazil opened this issue Oct 28, 2020 · 1 comment · Fixed by #3815
Closed

Color picker picks the wrong value if dialog has dark background #3798

strattonbrazil opened this issue Oct 28, 2020 · 1 comment · Fixed by #3815
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) 🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue

Comments

@strattonbrazil
Copy link

Describe the bug:
When using the chroma tool I noticed it was working very poorly. After playing with the colors I noticed the ones grabbed by the picker were much darker, which was the problem. I realized the color picker is actually pulling values off the screen--not the render view--so the dark overlay the dialog puts over the window (at least on my dialog rendering implementation) will alter the picked color. See screenshot below.

Steps to reproduce the behavior:

  1. Loading OpenShot
  2. Load color picker from effect property (ex. Chrome Key color)
  3. Select color from render view
  4. If dialog has darked the

Expected behavior:
A clear and concise description of what you expected to happen.

System Details:

  • OpenShot Version: 2.5.1
  • Operating System / Distro: Ubuntu 18.04

Screenshots:
color_picker_background

@strattonbrazil strattonbrazil added the 🐞 bug A bug, error, or breakage of any kind label Oct 28, 2020
@ferdnyc
Copy link
Contributor

ferdnyc commented Nov 1, 2020

I don't know how I didn't see this one along with #3799, but PR #3815 will fix this as well.

@ferdnyc ferdnyc added interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) pending A PR has been submitted to fix the issue labels Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) 🐞 bug A bug, error, or breakage of any kind pending A PR has been submitted to fix the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants