Use ColorPicker for all color dialogs #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdnyc
added
the
interface
|
LGTM! Is this ready to merge? If so, go for it. 👍 |
|
Merge conflicts have been detected on this PR, please resolve. |
|
@ferdnyc I resolved conflicts on this one. Can you take a quick looky, and make sure this all still works correctly. If so, let's merge it! Thanks! 👍 |
|
Merge conflicts have been detected on this PR, please resolve. |
|
Merging this one as well. I'm gonna be doing a bunch of testing over the weekend, and I really wanted this one included as well. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, building on #3813 (and, in fact, incorporating it, as it's a necessary prerequisite), this PR makes use of the replacement ColorPicker instead of QColorDialog, in all places where we accept a color as user input.
It also adds
*args, **kwargsto some of our dialog windows'__init__()functions, as I noticed they weren't there. As a result of that, we can't (and Qt can't) pass any standard Qt args to those functions, which means you can't do things like parent them.(Of course, the fac that our dialogs aren't parented or parentable is the only thing preventing them from also being modal-by-default, so it could be seen as a happy accident. Then again, it might be a good idea to properly parent them, so that Qt can clean them up for itself.)
Oh, yes, this one finally...
Fixes #3799 and fixes #3798