Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Square the PNG icon file #2060

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Square the PNG icon file #2060

merged 1 commit into from
Sep 4, 2018

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Sep 4, 2018

This one's kind of odd. Turns out the dimensions of openshot-qt.png are only 64 × 56, which is problematic for some desktop environments. (It's odd, too, because the .svg has square page dimensions, and the .ico file is a square 64x64. *shrug*)

We've been squaring it during packaging with ImageMagick, using this nonsense:

convert xdg/openshot-qt.png -virtual-pixel Transparent -set option:distort:viewport \
"%[fx:max(w,h)]x%[fx:max(w,h)]-%[fx:max((h-w)/2,0)]-%[fx:max((w-h)/2,0)]" \
-filter point -distort SRT 0 +repage <outfile>

But that's nuts, so I just re-exported from inkscape at 64x64. Fills the frame better, too.

The .png icon was 64x56, oddly. Re-exported from inkscape at 64x64.
@DylanC
Copy link
Collaborator

DylanC commented Sep 4, 2018

@ferdnyc - Wow, very strange dimensions indeed! Good find! 👍

@DylanC DylanC merged commit 566881e into OpenShot:develop Sep 4, 2018
@ferdnyc ferdnyc deleted the square-icon branch September 4, 2018 14:06
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Sep 4, 2018

Credit goes to the previous maintainers at rpmfusion. All I did was read through the spec file I inherited, find that convert line, and decide it was stupid and I wasn't going to keep doing that if I could help it. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants