Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter properties using localized label #3292

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Filter properties using localized label #3292

merged 1 commit into from
Mar 11, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Mar 11, 2020

The properties filter field should match on the translated display string, not the English property name.

Fixes #3287

@SuslikV
Copy link
Contributor

SuslikV commented Mar 11, 2020

It seems to be, that it works (this fix).

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 11, 2020

Excellent, thanks! Merging.

@ferdnyc ferdnyc merged commit acc6986 into develop Mar 11, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Mar 11, 2020

Now I have to remember to check the rest of our filter fields, at some point.

@ferdnyc ferdnyc deleted the ferdnyc-patch-1 branch March 11, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter box issue (Give your bug report a descriptive title)
2 participants