Add libselinux.so.1 to package allow list #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distros (Arch) don't use SELinux, so it won't be present on those systems. - Also, log an error if any file referenced by `ldd` as a dependency somehow can't be found when packaging.
ferdnyc
added
OS:Linux
ferdnyc
changed the title
|
GitLab builder says: So, that should hopefully be that. (Assuming it doesn't break any distros.) |
|
Merging this, it should be pretty safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inserts
libselinux.so.1into the inclusion list forcx_Freeze(normally it would be excluded as living in/libinstead of/usr/lib), because some distros (Arch) don't use SELinux, and the library can't be relied upon to be present on those systems.The AppImage developers reached the same conclusion ~ 2 years ago, and stopped excluding
libselinux.so.1from AppImage packaging with the official tools as well. (See AppImageCommunity/pkg2appimage#83)Also, adds a(Took that out in favor of moving thelog.ERRORlevel message if any of the files referenced in thelddoutput somehow can't be found when packaging.os.path.existscheck earlier in the logic.)Fixes #2278