Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading Unicode paths from 2.4 (#3624) #3664

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Fix loading Unicode paths from 2.4 (#3624) #3664

merged 1 commit into from
Oct 16, 2020

Conversation

MarcelWaldvogel
Copy link
Contributor

@MarcelWaldvogel MarcelWaldvogel commented Aug 11, 2020

This is the hotfix approach from #3624. It would be cleaner to not mess with the string representation of the file.

Coded adapted from the hotwiring I did for the 2.5.1 files, no in-branch testing, no test cases. Feel free to complain ;-)

@jonoomph
Copy link
Member

Looks solid to me! Thanks, let's merge it.

@jonoomph jonoomph merged commit 0a58c7a into OpenShot:develop Oct 16, 2020
@jonoomph
Copy link
Member

jonoomph commented Oct 20, 2020

Okay, this breaks. I should have headed the warnings, lol
"path": "apps/openshot-qt-git/src/\"/home/jonathan/Videos/TearsOfSteel.mp4\"",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants