Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender: Always show error msg, close window after #3790

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Oct 26, 2020

When the Blender launching hit certain types of non-Subprocess errors (like a PermissionError if, say, you set a directory as the Blender executable location), the interface wasn't showing a visible error message. (The error was only in the logs/console.)

Now, a QMessageBox.critical() is always shown. The Animated Titles dialog will automatically self-close after the user acknowledges it, because there's nothing they can do to fix the problem from in there.

Fixes a mention in an issue comment somewhere.

@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label Oct 26, 2020
@ferdnyc ferdnyc merged commit 6e50f1c into OpenShot:develop Oct 26, 2020
@ferdnyc ferdnyc deleted the blender-launching branch October 26, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant