-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display origin motions in motion #4144
base: feature/motion-forward
Are you sure you want to change the base?
Display origin motions in motion #4144
Conversation
e383b57
to
2f7d889
Compare
Talked with @emanuelschuetze that for origin the diff mode is sufficient and a selection is not necessary. |
Line numbering is now using the default line numbering mode from origin meeting. |
a4b81f3
to
b992697
Compare
Line numbering mode will be used from the current meeting if origin meeting settings not available. |
We need to further discuss what we are saving here. When just saving the origin meetings it could be that when revisiting a motion multiple origin motions are selected because it is possible to pass motions between meetings multiple times. Maybe it would be better to save the last selected level. |
Currently change recommendation do not get sent by the autoupdate service for users who are not in the origin meeting. Also meeting names do not get sent because the restriction mode for meeting names changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several problems which need to be solved:
Different changes to a motion which contains an amendment and in the amendment is a change reco are needed:
- currently two warning signs appear in motion view. -> wanted behavior: Only conflict should appear as warning.
- The change reco should get a new icon and should be replaced. The icon should be an Info icon which should have the the primary color and be inverted. The icon should be placed in the lower right corner of the amendment matcard.
- To avoid overlays with the three-dot-menu in an amendment, the three-dot-menu should be aligned higher and always centered to the first line of an amedment.
- Origin back view: If a user selects an origin view tab and scales the browser window, the tab snaps away from the selected tab -> Wanted: View should not change by scaling of window.
- Origin view tab: Is it possible to display the metadata in two columns? The back view needs a lot of space in the current design.
View as participant which has NO permission to see origin motions:
- Names of origin committees are not visible in the motion metadata -> Wanted: Names should appear
View as participant with the permission to see origin motions:
- Committee names are also missing. It is possible hit the switch of the origin motions, but the orgin committee names are also not visible as tabs. > Wanted: Committee names should be visible.
Below are a few points that were discussed in the previous step but not documented here. These are listed below for the sake of completeness:
- Origin view: Line number and motion view selection layout clashed with long motion titles
- If the origin view tab was opened once, the outlines of the matcard of the main motion and the origin view were not visible anymore
- Origin view: If the origin view contained amendments, the matcars of them didn't scale correctly by changing the window size.
Before this PR there were only meeting names displayed. We keep this behavior. |
I already talked about this with @emanuelschuetze. At the current stage we do not want to do this yet. |
resolves #3529