Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display origin motions in motion #4144

Open
wants to merge 41 commits into
base: feature/motion-forward
Choose a base branch
from

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Sep 17, 2024

resolves #3529

  • Categories and motion blocks loaded as meta data for the origin meeting are shown in the current meeting.
  • missing line numbering feature (currently reactive to line numbering from motion in meeting)
  • all polls are shown in the tab view
  • the "versions" are not selectable (diff, original, changed, final)
  • One can create a change recommandation in the orgin motion
  • The user of the forwarded motion is wrong
  • Tabs should be ordered
  • Missing fields
    • additional submitter
    • additional state
    • recommendation + extension
    • Referring motions (might be impossible)
  • Display amendment submitter in diff mode if "show amendments" enabled
  • display icon in diff mode if amendment has change recommendations
  • remove three dot menu from amendment in origin view
  • change recommendations in original motion missing
  • motion poll is linked to poll detail which cannot be opened
  • recommendation field is empty
  • permission check for amendment links
  • line numbers not displayed if not in origin meeting
  • add option to view final editorial version
  • display warning if amendment contains change recommendations
  • make motion metadata collapsible
  • keep origin toggle active when navigating

@bastianjoel bastianjoel self-assigned this Sep 17, 2024
@bastianjoel bastianjoel marked this pull request as ready for review September 18, 2024 11:34
@bastianjoel
Copy link
Member Author

Talked with @emanuelschuetze that for origin the diff mode is sufficient and a selection is not necessary.

@bastianjoel
Copy link
Member Author

Line numbering is now using the default line numbering mode from origin meeting.

@bastianjoel
Copy link
Member Author

bastianjoel commented Sep 23, 2024

The user of the forwarded motion is wrong

@rrenkert This is not part of #3529 if I understand correctly

@bastianjoel bastianjoel force-pushed the 3529-forwarded-motion branch from a4b81f3 to b992697 Compare February 3, 2025 11:14
@bastianjoel
Copy link
Member Author

Line numbering mode will be used from the current meeting if origin meeting settings not available.

@bastianjoel
Copy link
Member Author

keep origin toggle active when navigating

We need to further discuss what we are saving here. When just saving the origin meetings it could be that when revisiting a motion multiple origin motions are selected because it is possible to pass motions between meetings multiple times. Maybe it would be better to save the last selected level.

@bastianjoel
Copy link
Member Author

Currently change recommendation do not get sent by the autoupdate service for users who are not in the origin meeting. Also meeting names do not get sent because the restriction mode for meeting names changed.

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several problems which need to be solved:


Different changes to a motion which contains an amendment and in the amendment is a change reco are needed:

  • currently two warning signs appear in motion view. -> wanted behavior: Only conflict should appear as warning.
  • The change reco should get a new icon and should be replaced. The icon should be an Info icon which should have the the primary color and be inverted. The icon should be placed in the lower right corner of the amendment matcard.
  • To avoid overlays with the three-dot-menu in an amendment, the three-dot-menu should be aligned higher and always centered to the first line of an amedment.

  • Origin back view: If a user selects an origin view tab and scales the browser window, the tab snaps away from the selected tab -> Wanted: View should not change by scaling of window.
  • Origin view tab: Is it possible to display the metadata in two columns? The back view needs a lot of space in the current design.

View as participant which has NO permission to see origin motions:

  • Names of origin committees are not visible in the motion metadata -> Wanted: Names should appear

View as participant with the permission to see origin motions:

  • Committee names are also missing. It is possible hit the switch of the origin motions, but the orgin committee names are also not visible as tabs. > Wanted: Committee names should be visible.

Below are a few points that were discussed in the previous step but not documented here. These are listed below for the sake of completeness:

  • Origin view: Line number and motion view selection layout clashed with long motion titles
  • If the origin view tab was opened once, the outlines of the matcard of the main motion and the origin view were not visible anymore
  • Origin view: If the origin view contained amendments, the matcars of them didn't scale correctly by changing the window size.

@bastianjoel
Copy link
Member Author

bastianjoel commented Feb 19, 2025

Names of origin committees are not visible in the motion metadata -> Wanted: Names should appear

Committee names are also missing. It is possible hit the switch of the origin motions, but the orgin committee names are also not visible as tabs. > Wanted: Committee names should be visible.

Before this PR there were only meeting names displayed. We keep this behavior.
In case you mean that the meeting names are not displayed then you used an outdated autoupdate version. I verified that this works.

@bastianjoel
Copy link
Member Author

Origin view tab: Is it possible to display the metadata in two columns? The back view needs a lot of space in the current design.

I already talked about this with @emanuelschuetze. At the current stage we do not want to do this yet.

@bastianjoel bastianjoel requested a review from MSoeb February 19, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants