Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace yaml parse library #78

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Replace yaml parse library #78

merged 5 commits into from
Mar 28, 2024

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Feb 28, 2024 •
edited
Loading

resolves #70

Not yet tested with OpenSlides/openslides-meta#12

@bastianjoel bastianjoel added this to the 4.2 milestone Feb 28, 2024
jsangmeister
jsangmeister approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jsangmeister jsangmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, please test with OpenSlides/openslides-meta#12

@jsangmeister jsangmeister removed their assignment Feb 28, 2024
@bastianjoel
Copy link
Member Author

Does not work

@jsangmeister
Copy link
Contributor

jsangmeister commented Mar 21, 2024 •
edited
Loading

New approach to fix the problems: Unmarshal the models.yml into a generic map, remove the _meta key, marshal it again into a YAML string and unmarshal the new string again into the model classes. This solves the problem of the artificial "meta model" as well as the indentation problem, since during the first unmarshal, all aliases will be replaced with their anchors. Therefore, not changes to the models.yml are needed with this approach.

@jsangmeister jsangmeister assigned bastianjoel and unassigned rrenkert Mar 21, 2024
@jsangmeister jsangmeister mentioned this pull request Mar 21, 2024
Closed
@bastianjoel bastianjoel merged commit 68a9a2a into OpenSlides:main Mar 28, 2024
1 check passed
@bastianjoel bastianjoel deleted the yaml-lib-update branch March 28, 2024 13:43
@bastianjoel bastianjoel mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsangmeister jsangmeister jsangmeister approved these changes

@rrenkert rrenkert Awaiting requested review from rrenkert

Assignees

@bastianjoel bastianjoel

Labels
dependencies
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Update YAML parser to be able to parse anchors and aliases
3 participants
@bastianjoel @jsangmeister @rrenkert