Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches in workspace search bar return entries whose tabs match, but not repositories search #828

Closed
pgleeson opened this issue Nov 27, 2023 · 7 comments
Assignees
Labels
T: bug Something isn't working
Milestone

Comments

@pgleeson
Copy link
Member

e.g. search for "ecog" - this will return LFPy in workspaces search, but the repository LFPy is missing from repository seach results.

@pgleeson pgleeson added the T: bug Something isn't working label Nov 27, 2023
@pgleeson pgleeson added this to the v0.7.5 milestone Nov 27, 2023
@D-GopalKrishna
Copy link
Contributor

Just to clarify: Few questions:

  1. Does the feature work well in workspace and not in repositories?
    a. Does that mean the feature - searches for tags instead of names?
  2. Is LFPy name of the workspace? It's not present in the public workspaces. So can you please elaborate @pgleeson?

cc @filippomc

@pgleeson
Copy link
Member Author

pgleeson commented Dec 4, 2023

  1. Yes, searching for ecog in workspaces (on v2 live) returns this as the only featured workspace found: https://www.v2.opensourcebrain.org/workspace/188, and the only reason it matches is the tag EGoC. Ideally the search should cover title & tags, all independent of capitalisation. The issue is that searching in resources doesn't search in the tags
  2. See https://v2.opensourcebrain.org/workspace/188. Note: this repo should show up in a search on repos for ecog, as it has that tag: https://v2.opensourcebrain.org/repositories/32

@pgleeson
Copy link
Member Author

pgleeson commented Dec 5, 2023

Not sure if this is related to fixes for this, but it seems that when I type in the search box, tags get automatically added to the tag filter, even if I delete and retype in the search box. Tested on v2dev

Screenshot 2023-12-05 at 15 13 46

@D-GopalKrishna
Copy link
Contributor

thanks for the explaination @pgleeson !

I noticed the same issue as you mentioned and will be fixing the tags issue with this one.

@pgleeson
Copy link
Member Author

pgleeson commented Dec 7, 2023

Current workspace Search on live is worse than it was... searching for a term adds it to the tabs filter, and matches on that. However if you remove it from the tabs filter is returns either no entries or all entries.
Basic search on workspaces is broken, please prioritise...

@filippomc
Copy link
Contributor

@pgleeson please check the latest on https://v2dev.opensourcebrain.org/. Works as you described from my tests

@pgleeson
Copy link
Member Author

Looks good! It would be great to get a hot fix with these changes on live asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants