Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production build broken #3

Open
samhh opened this issue Sep 5, 2017 · 2 comments
Open

Production build broken #3

samhh opened this issue Sep 5, 2017 · 2 comments
Labels

Comments

@samhh
Copy link
Contributor

samhh commented Sep 5, 2017

This is due to Uglify not supporting ES6+.

Take -p out of the build command and manually pass the NODE_ENV instead if needed.

@samhh samhh added the bug label Sep 5, 2017
@JeremyRH
Copy link
Contributor

Babel has the option to transpile to es5 always.
https://github.com/babel/babel-preset-env#forcealltransforms

@samhh
Copy link
Contributor Author

samhh commented Sep 30, 2017

In that case we could simply change the env preset to ES5, but that's going to result in worse code/larger payloads being delivered to browsers that we can assume will be modern based upon our browser support. babili is already in there to handle uglification/minification so that -p is unneeded anyway (once env var is passed in differently). This issue was more a reminder for me than anything else. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants