Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

conditional sampling #33

Merged
merged 48 commits into from
Jul 4, 2020
Merged

conditional sampling #33

merged 48 commits into from
Jul 4, 2020

Conversation

peisenha
Copy link
Contributor

We need the ability to generate samples from the conditional distribution of correlated input paramters. We take our next steps here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@peisenha peisenha requested a review from loikein June 19, 2020 10:33
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #33 into master will increase coverage by 2.86%.
The diff coverage is 94.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   89.10%   91.96%   +2.86%     
==========================================
  Files           9       10       +1     
  Lines         156      249      +93     
==========================================
+ Hits          139      229      +90     
- Misses         17       20       +3     
Impacted Files Coverage Δ
econsa/tests/test_sampling.py 92.72% <92.72%> (-7.28%) ⬇️
econsa/sampling.py 95.83% <95.83%> (+95.83%) ⬆️
econsa/tests/wrapper_r.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fded4f0...e75d8f6. Read the comment docs.

@loikein
Copy link
Contributor

loikein commented Jun 23, 2020

Reporting to rpy2.

@loikein
Copy link
Contributor

loikein commented Jun 24, 2020

One possible way to move forward is to use the r channel instead of pip channel to install rpy2 and R together, and remove the action to install R seperately. However, the rpy2 package from that channel is outdated, I was worried it may cause compatibility issues with my code.

TODO: 2020-06-25
Result: conda cannot solve environment conflicts.

@loikein
Copy link
Contributor

loikein commented Jun 24, 2020

Codacy is constantly unhappy about my asserting error message.

Try adding a .bandit file according to Issue #346 · PyCQA/bandit… didn't worrk.

Reference: Code Patterns – Codacy.

@loikein loikein removed their request for review June 25, 2020 13:11
@peisenha peisenha requested a review from loikein July 4, 2020 07:54
@loikein loikein merged commit c6a3bbe into master Jul 4, 2020
@loikein loikein deleted the conditional-sampler branch July 4, 2020 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants