Fix #98: Make hyperlinks open in new tab #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavsingh97
suggested changes
Sep 10, 2017
oshc/main/templates/index.html
Outdated
| @@ -45,7 +45,7 @@ <h3 class="panel-title">{{ session.title }}</h3> | |||
| <div class="line-gap-10px"></div> | |||
| <i>{{ session.start_date }} - {{ session.end_date }}</i> | |||
| <div class="line-gap-10px"></div> | |||
| <button type="button" class="btn btn-lg btn-primary sRegister"> | |||
| <button type="button" class="btn btn-lg btn-primary s"> | |||
There was a problem hiding this comment.
extraneous change. @abhishekarya286 Please don't change anything that are not relevant to the issue.
There was a problem hiding this comment.
Sorry, I did this by mistake. I have edited it now.
There was a problem hiding this comment.
@abhishekarya286 It's ok to make mistakes 😉
One learn from his mistakes
|
LGTM |
|
Thanks @vaibhavsingh97!! |
vaibhavsingh97
approved these changes
Sep 10, 2017
|
@abhishekarya286 You are so fast!! 👍This PR is ready to merge. |
nikhita
approved these changes
Sep 10, 2017
| @@ -15,7 +15,7 @@ | |||
| <div class="container"> | |||
| <h3>Our Mission</h3> | |||
| <p class="bi"> | |||
| <b>"</b>Open Source Help Community is an a virtual platform to help people to start contributing to open source projects<b>"</b> | |||
| <b>"</b>Open Source Help Community is a virtual platform to help people to start contributing to open source projects<b>"</b> | |||
There was a problem hiding this comment.
thanks for this fix too. :)
|
@abhishekarya286 Congratulations on getting your first PR merged in OSHC! 😄 |
|
Thanks @nikhita |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
website, the browser would open it in a new tab.