Removed django-registration-redux #106
Conversation
vaibhavsingh97
requested review from
tapaswenipathak,
anubhakushwaha and
nikhita
| ('Ibrahim Jarif','jarifibrahim@gmail.com'), | ||
| ('Tapasweni Pathak', 'tapaswenipathak@gmail.com'), | ||
| ('Nikhita Raghunath', 'nikitaraghunath@gmail.com'), | ||
| ('Ibrahim Jarif', 'jarifibrahim@gmail.com'), |
There was a problem hiding this comment.
@vaibhavsingh97 Please remove these spaces
There was a problem hiding this comment.
@anubhakushwaha According to PEP 8, we should have spaces. If you want i can remove.
There was a problem hiding this comment.
@vaibhavsingh97 Ooh that's interesting, we would love to learn more,Is this the place? https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces
There was a problem hiding this comment.
oshc/oshc/settings.py
Outdated
| LOGIN_REDIRECT_URL = 'home' | ||
| # and are trying to access pages requiring authentication | ||
| LOGIN_URL = '/accounts/login/' | ||
| LOGOUT_REDIRECT_URL = 'home' | ||
|
|
There was a problem hiding this comment.
@vaibhavsingh97 Remove this extra line
|
@anubhakushwaha I had made suggested change. Please merge |
|
@vaibhavsingh97 Just mention the reason for the decrease in coverage for everyone and it's ready to be merged. |
|
@anubhakushwaha @tapasweni-pathak @nikhita Please find the detailed report 📓 Reason for decrease in coverageBefore removal of test case:
Statement covered: 102 After removal of test case:
Statement covered: 51 |
|
Merging, keeping the two commits separate just as a reminder that we have removed the test cases as well. |
Status:
Which issue does this PR fix?:
fixes #104
Brief description of what this PR does:
This PR is for removing django-registration-redux model.