Migrate Private Django Flat Blocks to HTMLs #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GoFroggyRun would you mind naming this something more informative and adding a [WIP] label? |
GoFroggyRun
changed the title
|
@hdoupe thanks for the reminder. |
|
@GoFroggyRun Thanks for updating the title |
GoFroggyRun
changed the title
|
@GoFroggyRun there are a couple merge conflicts. Can you take a look at those? |
|
@hdoupe should be good now. |
This was referenced Oct 26, 2017
hdoupe
reviewed
Oct 31, 2017
| @@ -73,8 +149,26 @@ <h2 class="sr-only">TaxBrain</h2> | |||
|
|
|||
| <div id="get-started" class="inputs-block inputs-block-intro"> | |||
| <div class="inputs-block-header"> | |||
| <h1>Macroeconomic Elasticity Simulation</h1> | |||
| {% flatblock "dynamic_elasticity_get_started_blurb" %} | |||
There was a problem hiding this comment.
@GoFroggyRun Here's where "Macroeconomic Elasticity Simulation" got removed. Fixed in #722
hdoupe
reviewed
Oct 31, 2017
| @@ -7,8 +7,7 @@ | |||
|
|
|||
| {% block content %} | |||
| <div class="inputs-block-header"> | |||
| <h1>Macroeconomic Parameter</h1> | |||
| {% flatblock "taxbrain_dynamic_blurb" %} | |||
| <h1>Macroeconomic Parameters</h1> | |||
There was a problem hiding this comment.
@GoFroggyRun And here's where the "s" got added back on. Fixed in #722
There was a problem hiding this comment.
@hdoupe right. Git automatically takes care of some conflicts. That's why changes got reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #588.
Previously, contents on the ospc.org are stored in private Django flatblocks, and is not open. All those flatblocks are now migrated into HTML files on PolicyBrain page.