Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Legend to Bubble Plot #809

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

andersonfrailey
Copy link
Contributor

This PR resolves issue #764 and adds a legend to the bubble plot shown after running the cost of capital calculator.

I opted to add a second Bokeh figure to act as the legend because Bokeh's legend feature does not allow you to use circle of different sizes and it let me add the "Asset Amount" title easily.

cc @hdoupe @jdebacker

@hdoupe
Copy link
Collaborator

hdoupe commented Jan 19, 2018

LGTM. Thanks for the contribution @andersonfrailey. @jdebacker Thanks for reviewing.

@hdoupe hdoupe merged commit eafbae8 into ospc-org:master Jan 19, 2018
@hdoupe hdoupe mentioned this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants