Upgrade to Tax-Calculator 0.19.+ #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 26, 2018 17:01
…r message dict structure
|
PR #887 is almost ready to go. However, it depends on the TC fix from PR PSLmodels/Tax-Calculator#1982. @martinholmer when can PolicyBrain expect the next Tax-Calculator release? |
|
@hdoupe, conda packages for Tax-Calculator 0.20.1 are now available. |
|
Thanks for the update @martinholmer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades PolicyBrain to TC 0.19.0+. In order to do so, the warning/error message parsing needed to be updated to comply with the format introduced by PSLmodels/Tax-Calculator#1952. The current changes were tested against the head of the Tax-Calculator master branch at commit a83f298.
A few more minor changes need to be made to complete this upgrade.