Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug reported in issue #1980 #1982

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Fix bug reported in issue #1980 #1982

merged 1 commit into from
Apr 25, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request fixes a bug reported by @hdoupe in issue #1980 using the code revisions he suggested here.

@hdoupe
Copy link
Collaborator

hdoupe commented Apr 25, 2018

LGTM. Thanks again for the quick response.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #1982 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1982   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3755    3755           
======================================
  Hits         3755    3755
Impacted Files Coverage Δ
taxcalc/parameters.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19098df...e87c616. Read the comment docs.

@martinholmer martinholmer merged commit f555ec7 into PSLmodels:master Apr 25, 2018
@talumbau talumbau removed the ready label Apr 25, 2018
@martinholmer martinholmer deleted the fix-i1980-bug branch April 28, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants