-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use heroku container registry to deploy the webapp #889
Conversation
It looks like most projects store staticfiles within the project directory. I plan to continue to do this unless we run into issues with this down the road. |
This version of the app is up at https://ospc-docker-test.herokuapp.com/ if anyone is interested in testing it out. |
I moved the app to https://ospc-test.herokuapp.com/ to make sure it was primarily under the main OSPC heroku account. |
Status update: As soon as I get this working, a new PB version will be released. I'm having some issues with the staticfiles that only came up when I merged in changes from last week. Hopefully, I can get this taken care of and a release out soon. |
PR #889 is ready to go.
Next up:
|
This PR follows the advice given in the heroku/conda-buildpack repo which recommends that apps should deploy from the container registry instead of a buildpack. To complete this PR, I need to:
This PR follows up on the initial work in converting PolicyBrain to Python 3 in #886.