Skip to content
This repository has been archived by the owner on Feb 7, 2021. It is now read-only.

Plugin name in snapshots have been lost #5

Closed
mpeyper opened this issue Feb 3, 2021 · 2 comments · Fixed by #13 or #15
Closed

Plugin name in snapshots have been lost #5

mpeyper opened this issue Feb 3, 2021 · 2 comments · Fixed by #13 or #15
Assignees

Comments

@mpeyper
Copy link
Member

mpeyper commented Feb 3, 2021

in #4 the name of plugin name used in the the snapshots have been lost for an unknown reason (and likely the test log too).

It's seemingly unrelated to changes in #4, and more likely caused by an upgrade to one of the dependencies (e.g. kcd-scripts that controls the babel config), and I suspect it will sort itself out when the index.js file is converted to TS, but if not, we will need to revisit this issue and work out what is going on before completing the raid.

@mpeyper
Copy link
Member Author

mpeyper commented Feb 4, 2021

I have discovered that this is fixed with the pluginName option passed to pluginTester as per babel-plugin-codegen:

pluginTester({
  plugin,
  pluginName: 'preval',
  // ...
})

This should be done as part of migrating the tests (trying to do so now seems to cause the test it to fail linting).

@mpeyper
Copy link
Member Author

mpeyper commented Feb 5, 2021

This will be resolved one #13 an #15 are merged.

@mpeyper mpeyper self-assigned this Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant