This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Add history #19
Merged
Add history #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick thought after looking at the model: Don't you also need the corresponding group as a foreign key? Otherwise you have a event with "new user joined, userid: 4" but don't know which group this belongs to :D |
|
The event_id is bound to the payment or transaction id, so you can get all of these for a group and then query the ids from the history entries. Another aspect is the deletion of entries should not delete them completly from the database because then it would be hard to get them for the history after deletion. Will look into that. |
|
This fixes #13 |
mweinelt
reviewed
Dec 19, 2018
| group_id = Column(Integer, ForeignKey('group.id'), nullable=False) | ||
| event_type = Column(String(60), nullable=False) | ||
| user_id = Column(Integer, ForeignKey('user.id')) | ||
| expense_id = Column(Integer, ForeignKey('user.id')) |
There was a problem hiding this comment.
Foreign-key copy-pasta issue?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation and to track status of the implementation of a history model as stated in #13