-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Extend Swagger Coverage for controller OAuth2SummitOrdersApiController
#450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Extend Swagger Coverage for controller OAuth2SummitOrdersApiController
#450
Conversation
| summary: 'Reserve tickets in an order', | ||
| description: 'Creates a reservation for tickets. Can be called anonymously or by authenticated users.', | ||
| security: [['bearer' => []]], | ||
| tags: ['orders'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be Orders with Cap letter
| path: '/api/v1/summits/{summit_id}/orders', | ||
| summary: 'Get all orders for a summit', | ||
| description: 'Returns paginated list of orders for the specified summit. Admin access required.', | ||
| security: [['bearer' => []]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo missing security schema
u need to define a new one for SummitOrders under swagger folder using the proper scopes please do check as example
summit-api/app/Http/Controllers/Apis/Protected/Summit/OAuth2RSVPApiController.php
Line 88 in c070afa
| SummitScopes::AddMyRSVP, |
please apply to all endpoints under OAUTH2
smarcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo please review comments
Task:
Ref: https://app.clickup.com/t/86b6wkhct