Skip to content

Conversation

@andrestejerina97
Copy link
Contributor

@andrestejerina97 andrestejerina97 marked this pull request as ready for review November 5, 2025 19:08
operationId: 'getSpeakers',
description: 'Get all speakers for a summit with filtering and pagination',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrestejerina97 u need to defined a custom security schema for speakers with the proper scopes this is not enough please do review

operationId: 'getSpeakersCSV',
description: 'Export speakers for a summit as CSV file',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId: 'getSpeakersOnSchedule',
description: 'Get speakers with presentations on schedule for a summit',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responses: [
new OA\Response(
response: Response::HTTP_OK,
description: 'List of speakers on schedule',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List of Speakers that belongs to Summit Schedule

operationId: 'getAllSpeakers',
description: 'Get all speakers (without summit filter)',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[OA\Get(
path: '/api/v1/speakers',
operationId: 'getAllSpeakers',
description: 'Get all speakers (without summit filter)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get All Global Speakers

operationId: 'getSummitSpeaker',
description: 'Get a specific speaker by ID for a summit',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path: '/api/v1/summits/{id}/speakers/me',
operationId: 'getMySummitSpeaker',
description: 'Get current user speaker profile for a summit',
parameters: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing security schema

operationId: 'getMySpeaker',
description: 'Get current user speaker profile',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId: 'createMySpeaker',
description: 'Create speaker profile for current user',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId: 'updateMySpeaker',
description: 'Update current user speaker profile',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security: [['bearer_token' => []]],
requestBody: new OA\RequestBody(
required: true,
content: new OA\JsonContent(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define a custom schema at Swagger/SummitSpeakers.pjp

security: [['bearer_token' => []]],
requestBody: new OA\RequestBody(
required: true,
content: new OA\JsonContent(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operationId: 'getSpeaker',
description: 'Get speaker by ID',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
requestBody: new OA\RequestBody(
required: true,
content: new OA\JsonContent(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define a custom schema at Swagger/SummitSpeakers.php

operationId: 'updateSpeakerBySummit',
description: 'Update speaker for a summit',
tags: ['SummitSpeakers'],
security: [['bearer_token' => []]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

],
requestBody: new OA\RequestBody(
required: true,
content: new OA\JsonContent(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema: new OA\Schema(type: 'integer')
),
],
requestBody: new OA\RequestBody(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrestejerina97 please review comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants