Fix initialization of new profiles' blocked pins and counts #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old code used to assume that the profiles were copied from profile 1 and/or the pins blocked by addon API calls, such that all profiles' assigned to addon/reserved pins were already set that way. however, now creating new profiles, setProfileOptions might have to do that for the first time
|
Resolves #1155. |
|
Tested, works perfectly! |
arntsonl
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two fatal bugs:
RESERVEDorASSIGNED_TO_ADDONactions, because the old code assumed other methods were populating those profiles' values, but that is not possible on a totally new profile.