Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GpioAction for sustaining 4/8 way mode #1260

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Add GpioAction for sustaining 4/8 way mode #1260

merged 2 commits into from
Jan 9, 2025

Conversation

Pelsin
Copy link
Contributor

@Pelsin Pelsin commented Jan 8, 2025 •
edited
Loading

Would be interested to know if there is another preferred to handle fourWayMode in Gamepad

@Pelsin Pelsin marked this pull request as ready for review January 8, 2025 00:35
arntsonl
arntsonl requested changes Jan 8, 2025
View reviewed changes
headers/gamepad.h Outdated Show resolved Hide resolved
proto/enums.proto Outdated Show resolved Hide resolved
src/gamepad.cpp Outdated Show resolved Hide resolved
src/gamepad.cpp Outdated Show resolved Hide resolved
src/gamepad.cpp Outdated Show resolved Hide resolved
arntsonl
arntsonl approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly how I would implement it too, looks great!!

@arntsonl arntsonl merged commit eaef4ea into OpenStickCommunity:main Jan 9, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pelsin @arntsonl