Fix --affine CLI parameter #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Could you plase also extend the CLI help text for the --affine parameter with what exactly is overwritten? So the users don't need to fallback to the tutorial (maybe just print AffineStitcher.AFFINE_DEFAULTS)
I also thought if it make sense to make a input validation for AffineStitcher that such a mistake can not happen again. E.g. that is validated that the kwargs don't diverge from the AFFINE_DEFAULTS. Such a validation would have made the CLI error immediately visible.
What are your thoughts?
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This looks great @lukasalexanderweber! Thanks for picking it up! I didn't have time to dig into it last week. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a fix for #243
Here is the contents of
00_stitcher.txtwith the following command after these changes:Command:
sudo docker run --rm -v ./:/data openstitching/stitch --affine --verbose ./*.jpgResult
00_stitcher.txt:AffineStitcher(**{'medium_megapix': 0.6, 'detector': 'orb', 'nfeatures': 500, 'matcher_type': 'affine', 'range_width': -1, 'try_use_gpu': False, 'match_conf': None, 'confidence_threshold': 1, 'matches_graph_dot_file': None, 'estimator': 'affine', 'adjuster': 'affine', 'refinement_mask': 'xxxxx', 'wave_correct_kind': 'no', 'warper_type': 'affine', 'low_megapix': 0.1, 'crop': True, 'compensator': 'no', 'nr_feeds': 1, 'block_size': 32, 'finder': 'dp_color', 'final_megapix': -1, 'blender_type': 'multiband', 'blend_strength': 5, 'timelapse': 'no'})