Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching bug with relative end time #10

Closed
tsuna opened this issue Feb 12, 2011 · 3 comments
Closed

Caching bug with relative end time #10

tsuna opened this issue Feb 12, 2011 · 3 comments
Assignees
@tsuna
Labels
bug medium

Comments

@tsuna
Copy link
Member

tsuna commented Feb 12, 2011

Apparently StumbleUponArchive/opentsdb@b85f760 didn't fully fix the issue, some graphs are still not getting regenerated when requested with a relative end time (e.g. end=7d-ago).
@aravind
Copy link
Contributor

aravind commented May 9, 2011

Can you give any concrete examples to reproduce the issue?

@tsuna
Copy link
Member Author

tsuna commented May 10, 2011

http://www/~barr/stumbles-daybyweek.html (internal URL at StumbleUpon) shows the issue. Hit that URL, wait a couple hours, hit it again, you'll see.

tsuna added a commit to tsuna/opentsdb that referenced this issue Jun 7, 2011
@tsuna
Fix the logic that serves file from cache and add unit tests.
b3a26c3 
This closes issue OpenTSDB#42.  I believe it also closes issue OpenTSDB#10, since
relative end-dates are no longer handled specially.

Change-Id: I9ee259e7ae94a677bc6fc366024ac385a91a1cdb
@ghost ghost assigned tsuna Jun 15, 2011
@tsuna
Copy link
Member Author

tsuna commented Jun 15, 2011

Found it, the bug is in the way max_age is computed in GraphHandler. If the end date is relative and far in the past, max_age will always be set to 1 day (86400 seconds) instead of being dependent on the time range covered by the request.

@tsuna tsuna closed this as completed in cfe10f7 Jul 12, 2011
vonbirdie added a commit to jzeeck/opentsdb that referenced this issue Aug 26, 2014
@vonbirdie
Merge pull request OpenTSDB#10 from hi3g/test_hbase_store
681871a 
added test for the constructor
@arpitaagarwal arpitaagarwal mentioned this issue Oct 8, 2014
Open
@lynchlee lynchlee mentioned this issue Jan 15, 2016
Open
@mzw-g mzw-g mentioned this issue Oct 10, 2016
Closed
@CJosePhD CJosePhD mentioned this issue Feb 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuna tsuna

Labels
bug medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aravind @tsuna