Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to HTML5 doctype #12

Closed
tsuna opened this issue Feb 13, 2011 · 7 comments
Closed

Switch to HTML5 doctype #12

tsuna opened this issue Feb 13, 2011 · 7 comments
Assignees
@tsuna
Labels
easy http interface

Comments

@tsuna
Copy link
Member

tsuna commented Feb 13, 2011

Right now the TSD uses this doctype:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
It should instead be changed to use the HTML5 doctype:
<!DOCTYPE html>
@ghost ghost assigned tsuna Jun 7, 2011
@tsuna
Copy link
Member Author

tsuna commented Jun 9, 2011

Note: changing the doctype affects the way the UI is rendered by FF3 and Chrome dev. Some form elements are overlapping. Need to investigate why and fix it at the same time as the switch is made.

jzeeck added a commit to jzeeck/opentsdb that referenced this issue Aug 26, 2014
@jzeeck
Merge pull request OpenTSDB#12 from hi3g/id_name_optional
c99c014 
Return optionals from #getId and #getName in TsdbStore
@pfischermx pfischermx mentioned this issue Dec 12, 2015
Closed
@katameru katameru mentioned this issue Jun 16, 2016
Closed
@mzw-g mzw-g mentioned this issue Oct 10, 2016
Closed
@kaustubhmallik
Copy link

Is this issue still open? I want to take this.

@IDerr
Copy link

IDerr commented Jul 7, 2017

Seems already fixed

@manolama You can close this

@IDerr
Copy link

IDerr commented Jul 10, 2017

or @johann8384

@IDerr
Copy link

IDerr commented Aug 8, 2017

Any news on closing this ? @manolama @johann8384

@manolama
Copy link
Member

Thanks @IDerr It's still an issue that's a simple patch. Somewhere in the HttpRequest code I think.

manolama added a commit to manolama/opentsdb that referenced this issue Aug 11, 2017
@manolama
Fix OpenTSDB#12 by switching to the straight HTML DOCTYPE for the bui…
acf1ac0 
…lt-in UI.
manolama added a commit that referenced this issue Aug 11, 2017
@manolama
Fix #12 by switching to the straight HTML DOCTYPE for the built-in UI.
f371ba0 
Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
@manolama
Copy link
Member

Pushed in f371ba0 on next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuna tsuna

Labels
easy http interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsuna @manolama @kaustubhmallik @IDerr