Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the server-side filtering code for UIDs containing the byte 0x5C #25

Closed
tsuna opened this issue Mar 16, 2011 · 1 comment
Closed

Bug in the server-side filtering code for UIDs containing the byte 0x5C #25

tsuna opened this issue Mar 16, 2011 · 1 comment
Assignees
@tsuna
Labels
bug

Comments

@tsuna
Copy link
Member

tsuna commented Mar 16, 2011

Whenever a UniqueId happens to contain the byte 0x5C, the server-side scanner filter created by TsdbQuery.addId mistakenly escapes it. It shouldn't do that, because that's not how \Q...\E sequences work. There is no escaping possible in them. The only tricky case to handle is when there's a literal \E inside the sequence to escape.
@tsuna
Copy link
Member Author

tsuna commented Apr 9, 2011

Fix is being QA'ed (I fixed the bug immediately after finding it, but I got sidetracked and it fell through the cracks).

Pushed the fix here: tsuna/opentsdb@bc90c19
Will integrate it after QA.

@ghost ghost assigned tsuna Apr 19, 2011
@tsuna tsuna closed this as completed in f4d0459 Apr 20, 2011
jzeeck added a commit to jzeeck/opentsdb that referenced this issue Aug 26, 2014
@jzeeck
Merge pull request OpenTSDB#25 from hi3g/uid_formatter
2ed1d2b 
Create a UidFormatter class
@mzw-g mzw-g mentioned this issue Oct 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuna tsuna

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsuna