Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global annotations to graphs #773

Closed
HugoMFernandes opened this issue Apr 15, 2016 · 2 comments
Closed

Add global annotations to graphs #773

HugoMFernandes opened this issue Apr 15, 2016 · 2 comments
Labels
feature request

Comments

@HugoMFernandes
Copy link
Contributor

GraphHandler is currently not retrieving (or setting) global annotations when these are requested. All graphs ignore the queryParam "&global_annotations" and the gnuplot result is always missing the vertical lines (as it isn't retrieved or set).

I've fixed this (PR to follow) in GraphHandler.java because the codebase is actually handling queries differently in GraphHandler.java and QueryRpc.java (the code in GraphHandler is actually synchronous right now). In my opinion, both GraphHandler.java and QueryRpc.java should be refactored to separate query logic from the actual visualization (and thus, share the query logic code), but that's a much larger piece of work (we should probably open an issue for this).
HugoMFernandes added a commit to HugoMFernandes/opentsdb that referenced this issue Apr 15, 2016
@HugoMFernandes
Fix OpenTSDB#773 - Add global_annotations to graphs
8bb0a90 
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
@johann8384
Copy link
Member

Go ahead and open the issue for that, and I will take a look at this ASAP.

Thank you!
On Apr 15, 2016 9:09 AM, "HugoMFernandes" notifications@github.com wrote:

GraphHandler is currently not retrieving (or setting) global annotations
when these are requested. All graphs ignore the queryParam
"&global_annotations" and the gnuplot result is always missing the vertical
lines (as it isn't retrieved or set).

I've fixed this (PR to follow) in GraphHandler.java because the codebase
is actually handling queries differently in GraphHandler.java and
QueryRpc.java (the code in GraphHandler is actually synchronous right now).
In my opinion, both GraphHandler.java and QueryRpc.java should be
refactored to separate query logic from the actual visualization (and thus,
share the query logic code), but that's a much larger piece of work (we
should probably open an issue for this).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#773

@HugoMFernandes
Copy link
Contributor Author

Done (#775) and submitted PR for this one (#774). Cheers!

@HugoMFernandes HugoMFernandes mentioned this issue Apr 20, 2016
Open
manolama pushed a commit to manolama/opentsdb that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama
Fix OpenTSDB#773 - Add global_annotations to graphs
07ff47e 
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
manolama pushed a commit to manolama/opentsdb that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama
Fix OpenTSDB#773 - Add global_annotations to graphs
9f75c97 
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).
manolama pushed a commit that referenced this issue Apr 23, 2016
@HugoMFernandes @manolama
Fix #773 - Add global_annotations to graphs
3d55806 
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
johann8384 pushed a commit to johann8384/opentsdb that referenced this issue Dec 5, 2016
@HugoMFernandes @johann8384
Fix OpenTSDB#773 - Add global_annotations to graphs
e3ff79b 
Fixed a bug in which global_annotations were ignored by
GraphHandler.java (and thus, were not rendered by gnuplot). Added async
call to hbase to retrieve global annotations when required in a similar
fashion as that of QueryRpc.java.

Note: Since both GraphHandler.java and QueryRpc.java implement (similar)
query-processing logic, all of this should be unified in the future
(requires a large refactor to split all query logic with visualization
logic).

Signed-off-by: Chris Larsen <clarsen@yahoo-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johann8384 @HugoMFernandes