Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working with eclipse and maven #44

Closed
wants to merge 7 commits into from
Closed

working with eclipse and maven #44

wants to merge 7 commits into from

Conversation

tch
Copy link

@tch tch commented Apr 22, 2011

Hi,
I am currently experimenting with OpenTSDB (trying to plug it into esper cep engine). Could you please pull the following changes:

  • restructured source directory structure to match java packages (mainly for debugging purposes under eclipse)
  • updates to some 3rd party modules
  • added maven_install target for installation of tsdb.jar into local maven repo.

Tomasz

@tsuna
Copy link
Member

tsuna commented Apr 22, 2011

Hi,
Thanks for your contribution.
I don't want to restructure the directory hierarchy. Please configure Eclipse appropriately to work with the existing hierarchy.

The only change I can take here is the one that adds maven_install. OK?

@tch
Copy link
Author

tch commented Apr 22, 2011

OK -- go ahead with the maven_install part.
As for the source code hierarchy - it's a little bit unusual for the java world. I understand you are not planning on providing maven-based build?

@tsuna
Copy link
Member

tsuna commented Apr 22, 2011

I know it's a little bit unusual for most Java people, but all the Java tools support this different hierarchy too. Some IDEs like Eclipse might need just a little bit of tweaking in the project settings.

I do not intend to use maven or ant to build the project, you're right.

@tch
Copy link
Author

tch commented Apr 24, 2011

Out of curiosity - what the reason behind using make for builds? I would say that it's rather off-putting and may discourage people from contributing to the project...

@tsuna
Copy link
Member

tsuna commented Apr 24, 2011

Why would it discourage people? If you work in a terminal, you just have to type make instead of ant foo or maven bar. If you work with an IDE, you just have to tell your IDE to run make (it probably has built-in support for this anyway).

Issue #32 is about using autotools (autoconf and automake) for the project. These tools still provide the most portable and flexible build system around, and they're the best supported by all distros. Ant and Maven are, in my opinion, not very good. They don't even do proper dependency tracking out of the box, which is a show-stopper for me. They require you to use XML to define your build, which I find retarded. They're extremely slow and consume too much RAM. They're annoying to extend compared to just writing a Makefile rule that does what you want.

I know a lot of people don't like the Autotools because they're somewhat complicated to use. But if you know how to use them, there's no match for them, they've been the best build system for the past 10+ years. That's why so many open source projects use them.

@tch
Copy link
Author

tch commented Apr 24, 2011

I guess it's mostly about familiarity of java folk with maven/ant and
associated ecosystem (particularly large number of existing maven
plugins, integration with java ides, etc.). Choosing the autotools/make
course for java is unusual and I think there will be some unhappy voices.

I personally prefer maven as none of the arguments you mentioned below
has never really caused me much pain (particularly with the latest
rewrite of maven 3).

There are also new build tools on the horizon (ex. gradle/buildr) but
they more or less support maven.

But that's your choice - as long as I can get maven artifact of
opentsdb with attached javadoc and source that's good enough for me as a
user. However if you decide to provide maven build I would be happy to help.

Tomasz

On 24/04/11 17:16, tsuna wrote:

Why would it discourage people? If you work in a terminal, you just
have to type make instead of ant foo or maven bar. If you work
with an IDE, you just have to tell your IDE to run make (it
probably has built-in support for this anyway).

Issue #32 is about using autotools (autoconf and automake) for
the project. These tools still provide the most portable and
flexible build system around, and they're the best supported by all
distros. Ant and Maven are, in my opinion, not very good. They
don't even do proper dependency tracking out of the box, which is a
show-stopper for me. They require you to use XML to define your
build, which I find retarded. They're extremely slow and consume too
much RAM. They're annoying to extend compared to just writing a
Makefile rule that does what you want.

I know a lot of people don't like the Autotools because they're
somewhat complicated to use. But if you know how to use them,
there's no match for them, they've been the best build system for the
past 10+ years. That's why so many open source projects use them.

@tch tch closed this Apr 24, 2011
jzeeck pushed a commit to jzeeck/opentsdb that referenced this pull request Nov 25, 2014
Iterate directly over CompactedRows (prev RowSeqs) instead of going top down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants