Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Millisecond precision in tcollector.py #230

Closed
phil-dileo opened this issue Dec 8, 2015 · 2 comments
Closed

Millisecond precision in tcollector.py #230

phil-dileo opened this issue Dec 8, 2015 · 2 comments
Labels
feature request
Milestone
1.3.0

Comments

@phil-dileo
Copy link
Contributor

At line 54 you set the max ts to 10 digits which implies second precision. In the tcollector docs you mention that you can use 10 second precision but specify ms with NNNNNNNNNN.MMM but this fails the regex match on line 328.

Pythex example

Wondering how to create a collector that reports ms precision?
@phil-dileo
Copy link
Contributor Author

Ping

@tsuna
Copy link
Member

tsuna commented Jan 8, 2016

I don't think that's supported yet. Do you wanna send a pull request to fix the code so it accepts millisecond precision?

johann8384 added a commit to johann8384/tcollector that referenced this issue Feb 1, 2016
@johann8384
Add ms support, closes OpenTSDB#230
d578361
@johann8384 johann8384 mentioned this issue Feb 1, 2016
Merged
johann8384 added a commit that referenced this issue Feb 6, 2016
@johann8384
Merge remote-tracking branch 'origin/pr/238'
dc3acdc 
* origin/pr/238:
  Add ms support, closes #230
@johann8384 johann8384 added this to the 1.3.0 milestone Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@tsuna @johann8384 @phil-dileo